-
Notifications
You must be signed in to change notification settings - Fork 96
Add wrapper for char arrays to access str conveniently #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c419783 to
946d9f3
Compare
|
I will try to allocate sometime at Sunday to review this. |
|
By any chance, would you be able to finalize this PR anytime soon or should we take it over? It would be great to have it included in the next release (which will be in a week or so). |
|
Hey sorry @onur-ozkan I went a bit dark, work got in the way. |
I am not very familiar with recent TS integration as well. Maybe @patrickelectric could help to check that since he's the author of that integration. |
|
Could you please resolve conflicts when you have some free time? |
This adds a wrapper around char arrays that allows to access them either as slices or as strings. When accessing the string representation, it will automatically convert the char array to a string slice up to the first null byte.
|
I rebased and I believe I kept the intent behind #415, @patrickelectric would you be able to double check? |
Follow-up on #370
This adds a wrapper around char arrays that allows to access them either as slices or as strings. When accessing the string representation, it will automatically convert the char array to a string slice up to the first null byte.
A part I have some slight doubts about is the serde derives on the
CharArray<N>struct. If someone could validate that this is correct that would be great.